[Dropdown] Fix IE11 submenu selection triggered menu opening #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
changed the title
y0hami
removed
the
state/awaiting-reviews
lubber-de
added a commit
to lubber-de/Fomantic-UI
that referenced
this pull request
Nov 10, 2018
lubber-de
added a commit
to lubber-de/Fomantic-UI
that referenced
this pull request
Nov 10, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a submenu entry was selected from a dropdown, the Element got focus on IE11 and reopened the dropdown again. This was basically already fixed in case the dropdown had a searchmenu, but now it works anytime.
Testcase
https://jsbin.com/yofawovahi/edit?html,js,output
Screenshot (with applied fix)
Closes
Semantic-Org/Semantic-UI#6565
Semantic-Org/Semantic-UI#5965