Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] - Icon and wrapped image were not inline and wrapped or wrongly aligned #242

Merged

Conversation

lubber-de
Copy link
Member

Description

An icon aswell as wrapped image is not aligned properly within a horizontal list. A wrapped a.image > img was even breaking the whole horizontal list at all

Testcase

https://jsfiddle.net/Lk1n7gwh/1/

Screenshot

Before (when a wrapped a.image > img was used)

image

Before (when a usual img.image was used (like the example from the original SUI PR))

image

After

image

Closes

Semantic-Org/Semantic-UI#6653

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI labels Nov 10, 2018
@lubber-de lubber-de added the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 10, 2018
@lubber-de lubber-de self-assigned this Nov 10, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added this to the 2.6.4 milestone Nov 11, 2018
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 11, 2018
@y0hami y0hami merged commit 5b7ebae into fomantic:beta Nov 11, 2018
@lubber-de lubber-de deleted the fix/6653/horizontal_list_icon_not_inline branch November 11, 2018 18:38
@y0hami y0hami mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants