Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] image content images can go out of content and description does not wrap #209

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

lubber-de
Copy link
Member

Description

Using images within image content as suggested in the docs, which are too large, they overlay the modal and the description does not wrap

Original Fix provided by @GammaGames

Testcase

https://jsfiddle.net/j7qsb24n/

Closes

Semantic-Org/Semantic-UI#6636

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 26, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 28, 2018
@y0hami y0hami merged commit 83aa9e2 into fomantic:beta Oct 28, 2018
@lubber-de lubber-de deleted the fix/6636/image_content_large_images branch October 30, 2018 16:33
@lubber-de lubber-de added this to the 2.6.4 milestone Nov 5, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
@lubber-de
Copy link
Member Author

lubber-de commented Mar 29, 2019

I had to partly revert this. See #600 for workarounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants