Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Basic Modal and inverted modal on inverted dimmer had wrong close icon color #208

Merged
merged 2 commits into from
Oct 30, 2018
Merged

[Modal] Basic Modal and inverted modal on inverted dimmer had wrong close icon color #208

merged 2 commits into from
Oct 30, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Oct 26, 2018 •
edited
Loading

Description

  • Basic Fullscreen Modal had black close icon on black dimmer
  • Basic Modal on inverted dimmer had grey borders on action and header
  • Basic Modal on usual black dimmer had the borders aswell (although nearly invisible)
  • inverted modal on inverted dimmer in small viewports had black close icon on black modal

Black close icon when using basic fullscreen modal

Before:
image
After:
image

Border lines when using basic modal in inverted dimmer

Before:
image

After:
image

Black (thus invisible) close icon on small screen when using inverted modal in inverted dimmer

Before:
image

After:
image

Closes

Semantic-Org/Semantic-UI#5831

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 26, 2018
@y0hami
Copy link
Member

y0hami commented Oct 26, 2018

@lubber-de Can you add a screenshot of before and after?

@lubber-de
Copy link
Member Author

@hammy2899 Added them to the description

y0hami
y0hami previously approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami added this to the 2.6.4 milestone Oct 30, 2018
@y0hami y0hami merged commit c4c8037 into fomantic:beta Oct 30, 2018
@lubber-de lubber-de deleted the fix/5831/basicmodal_closeicon branch October 30, 2018 16:31
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 30, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho left review comments

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @y0hami @ColinFrick @prudho