Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] Fix check of svg support #192

Merged
merged 1 commit into from
Oct 23, 2018
Merged

[Popup] Fix check of svg support #192

merged 1 commit into from
Oct 23, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Oct 22, 2018 •
edited
Loading

Description

module.supports.svg was corrected to return true instead of false in case svg is supported by the browser

Closes

Semantic-Org/Semantic-UI#6118
Semantic-Org/Semantic-UI#5360
Semantic-Org/Semantic-UI#4517

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 22, 2018
ColinFrick
ColinFrick approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 23, 2018
@y0hami y0hami merged commit 7828b2f into fomantic:beta Oct 23, 2018
@lubber-de lubber-de deleted the fix/6118/svg_support_check branch October 23, 2018 07:24
@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Oct 30, 2018
@lubber-de lubber-de added this to the 2.6.4 milestone Nov 5, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @ColinFrick @prudho @y0hami