Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(statistic): add stackable variation #237

Merged
merged 1 commit into from
Nov 5, 2018
Merged

feat(statistic): add stackable variation #237

merged 1 commit into from
Nov 5, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Nov 5, 2018

Description

This PR add a stackable variation for the statistics group, allowing a single statistic per line display on mobile devices.

Screenshot

01b9908e0617b839c5bb579c7df21c0d.png

Closes

#152

@prudho prudho added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Nov 5, 2018
@prudho prudho added this to the 2.6.4 milestone Nov 5, 2018
@prudho prudho self-assigned this Nov 5, 2018
ColinFrick
ColinFrick approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit dd04a90 into fomantic:beta Nov 5, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 5, 2018
lubber-de
lubber-de reviewed Nov 9, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...ah..already merged... 🤣

@lubber-de lubber-de mentioned this pull request Nov 9, 2018
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Nov 9, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
@prudho prudho deleted the stackable-statistics branch April 11, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de left review comments

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

Assignees

@prudho prudho

Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@prudho @ColinFrick @y0hami @lubber-de