Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] data-value on <div> list items is ignored #224

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

lubber-de
Copy link
Member

Description

List style bullets given via data-value were ignored ondiv tags because the a) pseudo class was missing and b) nesting was not supported

Testcase

https://jsfiddle.net/6ohwqmxe/2/

Uncomment the CSS part to see the fix

Closes

Semantic-Org/Semantic-UI#5911

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Oct 29, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 30, 2018
@y0hami y0hami added this to the 2.6.4 milestone Oct 30, 2018
@y0hami y0hami merged commit 6af1487 into fomantic:beta Oct 30, 2018
@lubber-de lubber-de deleted the fix/5911/ordered_list_value_div branch October 30, 2018 16:31
@y0hami y0hami mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants