Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Header] Fix corner icon size in icon header #212

Merged
merged 1 commit into from
Oct 28, 2018
Merged

[Header] Fix corner icon size in icon header #212

merged 1 commit into from
Oct 28, 2018

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 28, 2018 •
edited
Loading

Description

Fix corner icon (SUI) does not look like corner in icon header (SUI)

Testcase

https://codepen.io/anon/pen/ajaEaj

Screenshot

Before After
image image

Closes

Semantic-Org/Semantic-UI#3281
Semantic-Org/Semantic-UI#6525

@exoego exoego changed the base branch from master to beta October 28, 2018 08:28
@exoego exoego changed the title [Header] Corner icon in icon header [Header] Fix corner icon size in icon header Oct 28, 2018
@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Oct 28, 2018
@ColinFrick ColinFrick added this to the 2.6.4 milestone Oct 28, 2018
ColinFrick
ColinFrick approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit f812030 into fomantic:beta Oct 28, 2018
@exoego exoego deleted the corner-icon-in-icon-header branch October 29, 2018 14:56
@exoego exoego mentioned this pull request Oct 30, 2018
Open
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami Awaiting requested review from y0hami

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@exoego @ColinFrick @lubber-de @y0hami