Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Stop Events after clicking outside of module #188

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Oct 19, 2018

Description

When clicking on a label of a select-dropdown it behaves like it would open the dropdown again after closing it. Indeed toggle() is called, but the previous event was hiding it before

Testcase

https://jsfiddle.net/d0aosr6q/1

  • Click on the label above the dropdown. It opens the dropdown.
  • Clicking again closes it, but opens it again.

Closes

Semantic-Org/Semantic-UI#6638

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 19, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit b9551d8 into fomantic:beta Oct 24, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 24, 2018
@lubber-de lubber-de deleted the fix/6638/dropdown_label_toggle branch October 24, 2018 07:34
@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Oct 30, 2018
@lubber-de lubber-de added this to the 2.6.4 milestone Nov 5, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants