Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Item of 'simple dropdown' in existing menus or 'simple floating' vanish preventing click #203

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Oct 25, 2018

Description

Items in a simple dropdown within an existing menu cannot be clicked, because the submenu vanishes right before clicking

Sidenote: this PR also fixes wrong comment block header in less file

Testcase

http://jsfiddle.net/pjga38wv/

Uncomment the CSS Part to see the fix

Screenshot

The right dropdown is the important one.

Before

simple_dd_bad

After

simple_dd_good

Also fixes simple pointing dropdown

Before

simple_pointing_dd_bad

After

simple_pointing_dd_good

Closes

Semantic-Org/Semantic-UI#2444
Semantic-Org/Semantic-UI#5322

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 25, 2018
@lubber-de lubber-de changed the title [Dropdown] Simple dropdown items in existing menus vanish preventing click [Dropdown] Item of 'simple dropdown' in existing menus or 'simple floating' vanish preventing click Oct 25, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Still the same old !important problems.

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 26, 2018
@y0hami y0hami merged commit 627e808 into fomantic:beta Oct 26, 2018
@lubber-de lubber-de deleted the fix/2444/simple_dd_2nd_menu_vanish branch October 26, 2018 13:05
@lubber-de lubber-de added this to the 2.6.4 milestone Nov 5, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants