-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Item] Inverted Variant #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should affect the background color, other inverted components only change text color and the background can be handled by the user via an inverted segment or custom CSS.
So I am removing inverteditemsbackground (which is currently set to black) only then. Because for items, extra and content there already was a background setting in the non inverted variant aswell, but set to transparent or none(as already discussed in the related issue) |
@hammy2899 i removed the black background, so it's up to the user now to set it accordingly. If i should remove those aswell, then just tell me 🙂 |
Maybe we should look into why the background is set by the item before we move forward. If it turns out it isn't for any reason maybe we should just not set it. |
The latest commit supports texts directly in the Regarding the background: Also in While reading through the code of all other elements/modules i could not see any other reason, why item needs to set the background (it was not even So i think we should follow that for item alone too. |
Ok with that being said then let's merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Inverted variant of Item.
Screenshot
Closes
#109