Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering search through URL doesn't work. #1630

Closed
c3ho opened this issue Feb 1, 2021 · 5 comments · Fixed by #1741
Closed

Triggering search through URL doesn't work. #1630

c3ho opened this issue Feb 1, 2021 · 5 comments · Fixed by #1741
Assignees
Labels
area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Milestone

Comments

@c3ho
Copy link
Contributor

c3ho commented Feb 1, 2021

What happened:
#1583 will land soon, triggering search through normal use works, but triggering search through URL doesn't work.

What should have happened:
Triggering search through search function AND url should work like it does in our current front-end

How to reproduce it (as precise as possible):
Does work:
Go to /search and choose a filter, type in text to search. Results will display

Does not work:
Type /search?filter=post&text=Telescope. No results will display.
Anything else we need to know?:

Environment:

  • OS: Mac
  • Browser: Chrome
@c3ho c3ho added type: bug Something isn't working area: front-end labels Feb 1, 2021
@DukeManh
Copy link
Contributor

DukeManh commented Feb 4, 2021

Hi, I can give this problem a try. My thinking is that we only need to access the router query after page load or access it every time it changes.

@humphd
Copy link
Contributor

humphd commented Feb 5, 2021

@DukeManh sounds good, go for it. Let us know how we can help.

@DukeManh
Copy link
Contributor

DukeManh commented Feb 5, 2021

Great, I will get started soon.

@DukeManh
Copy link
Contributor

DukeManh commented Feb 5, 2021

I filed #1657 to trigger search and update search box value through Url.

@chrispinkney chrispinkney linked a pull request Feb 6, 2021 that will close this issue
8 tasks
DukeManh added a commit to DukeManh/telescope that referenced this issue Feb 14, 2021
DukeManh added a commit to DukeManh/telescope that referenced this issue Feb 14, 2021
@DukeManh
Copy link
Contributor

The new properly rebased PR is #1741

DukeManh added a commit to DukeManh/telescope that referenced this issue Feb 15, 2021
@PedroFonsecaDEV PedroFonsecaDEV added this to the 1.7 Release milestone Feb 15, 2021
@PedroFonsecaDEV PedroFonsecaDEV added the area: nextjs Nextjs related issues label Feb 15, 2021
DukeManh added a commit to DukeManh/telescope that referenced this issue Feb 16, 2021
PedroFonsecaDEV added a commit that referenced this issue Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Projects
None yet
4 participants