-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triggering search through URL doesn't work. #1630
Labels
Milestone
Comments
Hi, I can give this problem a try. My thinking is that we only need to access the router query after page load or access it every time it changes. |
@DukeManh sounds good, go for it. Let us know how we can help. |
Great, I will get started soon. |
I filed #1657 to trigger search and update search box value through Url. |
8 tasks
8 tasks
DukeManh
added a commit
to DukeManh/telescope
that referenced
this issue
Feb 14, 2021
DukeManh
added a commit
to DukeManh/telescope
that referenced
this issue
Feb 14, 2021
The new properly rebased PR is #1741 |
DukeManh
added a commit
to DukeManh/telescope
that referenced
this issue
Feb 15, 2021
8 tasks
DukeManh
added a commit
to DukeManh/telescope
that referenced
this issue
Feb 16, 2021
PedroFonsecaDEV
added a commit
that referenced
this issue
Feb 16, 2021
Fix #1630 - triggering search via URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What happened:
#1583 will land soon, triggering search through normal use works, but triggering search through URL doesn't work.
What should have happened:
Triggering search through search function AND url should work like it does in our current front-end
How to reproduce it (as precise as possible):
Does work:
Go to /search and choose a filter, type in text to search. Results will display
Does not work:
Type /search?filter=post&text=Telescope. No results will display.
Anything else we need to know?:
Environment:
The text was updated successfully, but these errors were encountered: