Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1630 - triggering search via URL #1741

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix #1630 - triggering search via URL #1741

merged 1 commit into from
Feb 16, 2021

Conversation

DukeManh
Copy link
Contributor

@DukeManh DukeManh commented Feb 14, 2021 •
edited by PedroFonsecaDEV
Loading

Issue This PR Addresses

Fixes #1630

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@vercel
Copy link

vercel bot commented Feb 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/humphd/telescope/5lmaydn42
✅ Preview: https://telescope-git-fork-dukemanh-issue-1630b.humphd.now.sh

@DukeManh DukeManh mentioned this pull request Feb 14, 2021
Closed
@PedroFonsecaDEV PedroFonsecaDEV added this to the 1.7 Release milestone Feb 15, 2021
@huyxgit huyxgit requested a review from HyperTHD February 15, 2021 09:47
@HyperTHD HyperTHD mentioned this pull request Feb 16, 2021
Closed
humphd
humphd requested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix, and this is good to go!

src/frontend/next/src/components/SearchPage.tsx Show resolved Hide resolved
@PedroFonsecaDEV PedroFonsecaDEV merged commit ea1effa into Seneca-CDOT:master Feb 16, 2021
@DukeManh DukeManh deleted the issue-1630_b branch March 24, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroFonsecaDEV PedroFonsecaDEV PedroFonsecaDEV approved these changes

@humphd humphd humphd approved these changes

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

Assignees

@DukeManh DukeManh

Labels
area: front-end area: nextjs Nextjs related issues
Projects
None yet
Milestone
1.7 Release
Development

Successfully merging this pull request may close these issues.

Triggering search through URL doesn't work.
3 participants
@DukeManh @humphd @PedroFonsecaDEV