Fixes #1078: Banner Images Reload twice #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekenpix
changed the title
raygervais
requested changes
Oct 6, 2020
| @@ -4,7 +4,7 @@ import { makeStyles } from '@material-ui/core/styles'; | |||
| import KeyboardArrowDownIcon from '@material-ui/icons/KeyboardArrowDown'; | |||
| import { Fab, Grid, Typography, Link } from '@material-ui/core'; | |||
| import useSiteMetadata from '../../hooks/use-site-metadata'; | |||
| import DynamicBackgroundContainer from '../DynamicBackgroundContainer'; | |||
| import DynamicBackgroundContainer from '../DynamicBackgroundContainer.jsx'; | |||
There was a problem hiding this comment.
We don't need .jsx in imports. Let's remove in this case.
There was a problem hiding this comment.
Line 7, linter was yelling about this. 🤷♂️.
| [theme.breakpoints.between('xs', 'sm')]: { | ||
| left: '55%', | ||
| right: theme.spacing(4), |
There was a problem hiding this comment.
I think we missed a rebase commit here where you should have accepted remote 😄 d2b2e08, this would undo the commit that was previously done.
| @@ -219,7 +219,7 @@ export default function Banner() { | |||
| <Grid | |||
| container | |||
| spacing={0} | |||
| direction="row" | |||
| direction="column" | |||
There was a problem hiding this comment.
Same comment as above, this undoes recent commit d2b2e08.
|
Okay. I will work on it. Thanks. |
|
@raygervais Now our banner is the same. |
raygervais
approved these changes
Oct 6, 2020
humphd
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #1078
I believe now it is rebased and good to go.
Thanks.
Type of Change
Description
Checklist