-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1078: Banner Images Reload twice #1162
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import { makeStyles } from '@material-ui/core/styles'; | |
import KeyboardArrowDownIcon from '@material-ui/icons/KeyboardArrowDown'; | ||
import { Fab, Grid, Typography, Link } from '@material-ui/core'; | ||
import useSiteMetadata from '../../hooks/use-site-metadata'; | ||
import DynamicBackgroundContainer from '../DynamicBackgroundContainer'; | ||
import DynamicBackgroundContainer from '../DynamicBackgroundContainer.jsx'; | ||
|
||
const useStyles = makeStyles((theme) => ({ | ||
h1: { | ||
|
@@ -89,9 +89,9 @@ const useStyles = makeStyles((theme) => ({ | |
position: 'relative', | ||
bottom: theme.spacing(20), | ||
zIndex: 300, | ||
margin: '0 auto', | ||
[theme.breakpoints.between('xs', 'sm')]: { | ||
left: '55%', | ||
right: theme.spacing(4), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we missed a rebase commit here where you should have accepted remote 😄 d2b2e08, this would undo the commit that was previously done. |
||
left: '80%', | ||
bottom: theme.spacing(18), | ||
}, | ||
}, | ||
|
@@ -219,7 +219,7 @@ export default function Banner() { | |
<Grid | ||
container | ||
spacing={0} | ||
direction="row" | ||
direction="column" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above, this undoes recent commit d2b2e08. |
||
alignItems="center" | ||
justify="center" | ||
className={classes.container} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need
.jsx
in imports. Let's remove in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 7, linter was yelling about this. 🤷♂️.