upgrade project to dotnet core6.0 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunkn0wn1
commented
Sep 4, 2022
craig-johnston
pushed a commit
to craig-johnston/yafc
that referenced
this pull request
Jul 15, 2024
…moving milestones. (ShadowTheAge#183) Also recalculate the milestones when closing the editor so mass-unlock operations in the milestone window will behave properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a minimal effort upgrade to dotnet core 6.0 .
All projects in this repository have had their target platform manually upgraded.
I then ran Microsoft's upgrade utility.
Additionally, I allowed nuget to update the project's dependencies to current, which didn't seem to break anything.
Dotnet was complaining of a deprecated option in the json serialization, so I applied the quick fix it suggested.
Absent a unit test suite, I ran the newly compiled version of YAFC both on my windows box and my Ubuntu Jammy box, and haven't encountered any obvious issues or crashes.
Closes #182