-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AppVeyor (Windows) CI Build #955
Comments
The fix is documented in the PR #956 and by the commits coments. TLDR; The outdated miniconda version 36 has issues with the |
Thanks @ppk42 . |
…MixedNoise Likelihood class, appveyor CI resurrected (#951) This PR adds two main things to GPy: - to- and from-dict functions for the kernels listed belop - a fix for the appveyor CI Please see the squashed commit messages listed below. Authors: @gehbiszumeis @ppk42 respectively Reviewer: @ekalosak --- * new: added to_dict() method to Coregionalize kernel class * new: added to_dict() method to MixedNoise likelihood class * fix: made Y_metadata dict content serializable * fix: typo * added additional needed parameters to to_dict() method for Coregionalize kernel + added _build_from_input dict method * new: added possibility to build MixedNoise likelihood from input_dict * Y_metadata conversion from serializable to np.array when loading from dict * fix: rework Y_metadata part for compatibility with unittests !minor * conda cleanup in appveyors pipeline * conda clean up after conda update * conda clean before conda update * try pinning packages for conda * revert all conda changes * conda clean all (not only packages) * use conda update anaconda * pin conda package * pin conda package * try installing charset-normalizer beforehand * try to get from conda-forge * revert all conda changes * Try to fix the conda update challange. See: https://community.intel.com/t5/Intel-Distribution-for-Python/Conda-update-Conda-fails/td-p/1126174 It is just a try for a different context/(conda version). * Still fixing build error on appveyor I also use a newer miniconda version for greater python versions. * Update appveyor.yml Thinking it over it decided to use miniconda38 for all python versions unless python 3.5. * revert miniconda versioning changes * adjust GPy version in appveyor.yml * 1st attempt bring the appveyor build to life again * #955 fixing ci build on appveyor After bringing the miniconda env to work again, the wrong matplotlib version was used. This commit should fix that. * #955 Fix CI build Freezing numpy and scipy was a bad idea. I freeze matplotlib dependend on the python version only. * add: built_from_dict method for White Kernel Co-authored-by: Peter Paul Kiefer <ppk42@users.noreply.github.com> Co-authored-by: Peter Paul Kiefer <dafisppk@gmail.com>
I was aware of pull request #951. One of the prerequisites that must be fulfilled is a AppVeyor buld for the Windows version. The build only works for Python 3.5 but not for Python versions 3.6 up to 3.9.
The build is essential for further development. If it will not work, no pull requests can/should be accepted.
With the known facts, it seems that the build did not fail because of the code changes. There is evidence for the assumption that the build failed because of incompatibilities of the miniconda version and the
conda update conda
command.It is remarkable that the working case and the not working cases use different installation folders of the miniconda environment and, all not working cases use the same miniconda installation.
I would like to check these thoughts by forking the repo and adding pull requests with changes only for the appveyor.yml file that hopefully bring appveyors build to life again. ;-). It could also be possible that the ApVeyor configuration must be changed (e.g. another Visual Studio VM), but that's beyond my means. Only the owner of the AppVeyor project is granted to change it.
The text was updated successfully, but these errors were encountered: