to_dict() and from_dict() methods for Periodic Kernel #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize kernel + added _build_from_input dict method
See: https://community.intel.com/t5/Intel-Distribution-for-Python/Conda-update-Conda-fails/td-p/1126174 It is just a try for a different context/(conda version).
I also use a newer miniconda version for greater python versions.
Thinking it over it decided to use miniconda38 for all python versions unless python 3.5.
A try to get rid of the appveyor build error.
After bringing the miniconda env to work again, the wrong matplotlib version was used. This commit should fix that.
Freezing numpy and scipy was a bad idea. I freeze matplotlib dependend on the python version only.
# Conflicts: # GPy/kern/src/coregionalize.py
Codecov Report
@@ Coverage Diff @@
## devel #976 +/- ##
==========================================
- Coverage 54.50% 54.48% -0.02%
==========================================
Files 210 210
Lines 21557 21572 +15
Branches 3168 3168
==========================================
+ Hits 11750 11754 +4
- Misses 9253 9264 +11
Partials 554 554 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also a minor add to the W_rank variable in the
from_dict()method of the Coregionalize kernel classNote: relevant are actually only the 5 most recent commits. The previous once result from a merge of #955 in my devel branch