Conversation
This reverts commit 30362b8.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR reverts the feature-flag package from version 0.4.1 to 0.4.0, removing the associated changelog entry and applying minor formatting adjustments to test descriptions and code structure without functional changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/node/feature-flag/src/index.test.ts (1)
35-35: Double space in test description looks unintentionalThe description now has two spaces in
'should not validate a JSON feature flag'. If this isn’t required to match some external snapshot/history, consider reverting to a single space for readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
libs/node/feature-flag/CHANGELOG.md(0 hunks)libs/node/feature-flag/package.json(1 hunks)libs/node/feature-flag/src/index.test.ts(1 hunks)libs/node/feature-flag/src/index.ts(1 hunks)
💤 Files with no reviewable changes (1)
- libs/node/feature-flag/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
**/*
⚙️ CodeRabbit configuration file
We handle errors at the edge of our applications in most cases. Do not recommend to add error handling around every single function. We prefer them to bubble up and be handled at upper layers.
Files:
libs/node/feature-flag/package.jsonlibs/node/feature-flag/src/index.test.tslibs/node/feature-flag/src/index.ts
🔇 Additional comments (2)
libs/node/feature-flag/package.json (1)
5-5: Version rollback aligns with revert intentRolling the package version back to
0.4.0matches the PR’s goal of reverting the previous release; no issues from this file alone. Please just confirm there are no remaining references to0.4.1elsewhere in the workspace (e.g., changelog, docs, release config).libs/node/feature-flag/src/index.ts (1)
66-70: Formatting-only change tomapContextMultiline object literal is behaviorally identical to the previous version and improves readability; no issues here.
Reverts #214
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.