Skip to content

Revert "Chore/new ff version"#219

Merged
EnzalRad merged 1 commit intomainfrom
revert-214-chore/new_ff_version
Dec 10, 2025
Merged

Revert "Chore/new ff version"#219
EnzalRad merged 1 commit intomainfrom
revert-214-chore/new_ff_version

Conversation

@EnzalRad
Copy link
Contributor

@EnzalRad EnzalRad commented Dec 10, 2025

Reverts #214

Summary by CodeRabbit

  • Chores
    • Adjusted package version to 0.4.0 and updated changelog documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-ui Ready Ready Preview Comment Dec 10, 2025 1:52pm

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Walkthrough

This PR reverts the feature-flag package from version 0.4.1 to 0.4.0, removing the associated changelog entry and applying minor formatting adjustments to test descriptions and code structure without functional changes.

Changes

Cohort / File(s) Summary
Release Management
libs/node/feature-flag/CHANGELOG.md, libs/node/feature-flag/package.json
Removed 0.4.1 changelog section and downgraded package version from 0.4.1 to 0.4.0
Code Formatting
libs/node/feature-flag/src/index.ts
Reformatted mapContext return expression to multi-line object literal; no behavioral change
Test Updates
libs/node/feature-flag/src/index.test.ts
Updated test description text with whitespace adjustment; no assertion or logic changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Chore/new ff version #214: Directly modifies the same feature-flag files with opposing version/changelog and formatting changes, suggesting this PR may be reverting that release.
  • Chore: new ff release #212: Both PRs modify feature-flag package metadata (package.json version and CHANGELOG.md).
  • New version release #138: Both PRs update release metadata for the same libs/node/feature-flag package.

Suggested reviewers

  • noe-charmet
  • dvxam
  • kylengn

Poem

🐰 A version takes a step back,
Four-oh awaits the feature-flag track,
Formatting springs neat and bright,
Minor tweaks polish the light! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Revert "Chore/new ff version"' accurately describes the main change - this PR reverts a previous commit/PR, which is clearly demonstrated by the description and all the changes in the pull request that undo version updates and formatting changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-214-chore/new_ff_version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
libs/node/feature-flag/src/index.test.ts (1)

35-35: Double space in test description looks unintentional

The description now has two spaces in 'should not validate a JSON feature flag'. If this isn’t required to match some external snapshot/history, consider reverting to a single space for readability.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e01ee51 and 93dbadf.

📒 Files selected for processing (4)
  • libs/node/feature-flag/CHANGELOG.md (0 hunks)
  • libs/node/feature-flag/package.json (1 hunks)
  • libs/node/feature-flag/src/index.test.ts (1 hunks)
  • libs/node/feature-flag/src/index.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • libs/node/feature-flag/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

We handle errors at the edge of our applications in most cases. Do not recommend to add error handling around every single function. We prefer them to bubble up and be handled at upper layers.

Files:

  • libs/node/feature-flag/package.json
  • libs/node/feature-flag/src/index.test.ts
  • libs/node/feature-flag/src/index.ts
🔇 Additional comments (2)
libs/node/feature-flag/package.json (1)

5-5: Version rollback aligns with revert intent

Rolling the package version back to 0.4.0 matches the PR’s goal of reverting the previous release; no issues from this file alone. Please just confirm there are no remaining references to 0.4.1 elsewhere in the workspace (e.g., changelog, docs, release config).

libs/node/feature-flag/src/index.ts (1)

66-70: Formatting-only change to mapContext

Multiline object literal is behaviorally identical to the previous version and improves readability; no issues here.

@EnzalRad EnzalRad merged commit cabb3b1 into main Dec 10, 2025
4 checks passed
@EnzalRad EnzalRad deleted the revert-214-chore/new_ff_version branch December 10, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants