Rename biome task to biome-check to preserve the biome CLI#89
Rename biome task to biome-check to preserve the biome CLI#89noe-charmet merged 6 commits intomainfrom
biome task to biome-check to preserve the biome CLI#89Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA new changeset file is added documenting a minor version bump for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| --- | ||
| "@shipfox/biome": minor | ||
| --- | ||
|
|
||
| Rename biome task to biome-check |
There was a problem hiding this comment.
🧩 Analysis chain
Verify that the task rename is fully implemented across the codebase.
The changeset file is well-formatted and documents a minor version bump, which is appropriate for a rename. However, this changeset alone only documents the change—ensure that:
- The "biome" task has actually been renamed to "biome-check" in package.json (or equivalent task definition)
- All references to the old task name have been updated
- The "biome" CLI command is now properly exposed/preserved as intended
🏁 Script executed:
#!/bin/bash
# Description: Verify the task rename from "biome" to "biome-check" is complete
# Search for task definitions in common files
echo "=== Checking package.json scripts ==="
fd package.json --type f --exec cat {} \; | grep -A 20 '"scripts"'
# Search for remaining references to the old "biome" task (excluding this changeset)
echo -e "\n=== Searching for references to 'biome' task (excluding changesets) ==="
rg -n '"biome"\s*:' --type json --type yaml -g '!.changeset'
# Check for any npm/yarn script references
echo -e "\n=== Checking for 'biome-check' task definition ==="
rg -n 'biome-check' --type json --type yamlLength of output: 8838
🏁 Script executed:
#!/bin/bash
# Detailed verification of the biome task rename implementation
echo "=== Root package.json 'biome' task ==="
grep -A 1 '"biome"' package.json | head -2
echo -e "\n=== All occurrences of 'biome' task definition (not just description) ==="
rg -n '"biome"\s*:\s*"' --type json
echo -e "\n=== All occurrences of check scripts that reference 'biome' ==="
rg -n '"check"\s*:\s*"biome' --type json
echo -e "\n=== Check if bin/biome.js exists ==="
fd -t f -n "biome.js"
echo -e "\n=== Check tools/biome/bin/ structure ==="
fd . tools/biome/bin/ --type f 2>/dev/null || echo "No bin directory found"
echo -e "\n=== All references to 'biome-check' (full search) ==="
rg -n 'biome-check' 2>/dev/null | wc -lLength of output: 1340
The task rename is not implemented. The changeset documents a change that does not exist in the codebase.
The changeset claims to rename the "biome" task to "biome-check", but the actual rename is missing:
- Root
package.jsonstill defines:"biome": "pnpm --filter @shipfox/biome exec biome" tools/biome/package.jsonstill defines:"biome": "./bin/biome.js"- 10 packages still reference
"check": "biome"instead of"check": "biome-check" - Zero occurrences of "biome-check" found in the entire codebase
Either the implementation is missing from this PR or the changeset was added prematurely. Update all task definitions and references to complete the rename.
🤖 Prompt for AI Agents
In .changeset/famous-rockets-end.md lines 1-5: the changeset says "biome" was
renamed to "biome-check" but the codebase still uses "biome"; update the
implementation to match the changeset by renaming task entries and references:
change root package.json "biome" script to "biome-check": "pnpm --filter
@shipfox/biome exec biome-check", update tools/biome/package.json script from
"biome": "./bin/biome.js" to "biome-check": "./bin/biome.js" (or rename the
binary to bin/biome-check.js and update "bin" field), search and replace the 10
package.json scripts that have "check": "biome" to "check": "biome-check", and
add/update any package.json "bin" or CLI dispatchers so "biome-check" is a valid
executable; run a repo-wide search to ensure zero remaining "biome" task
references or update the changeset if you intend not to implement the rename.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
CI was failing because of this, latest changes should fix it
There was a problem hiding this comment.
@noe-charmet the CI is still failing though saying the biome-check not found, can you double check again?
2 participants
Summary by CodeRabbit