Skip to content

Rename biome task to biome-check to preserve the biome CLI #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noe-charmet merged 6 commits into from
Nov 6, 2025
Merged

Rename biome task to biome-check to preserve the biome CLI #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60739a4
Rename `biome` task to `biome-check` to preserve the `biome` CLI
noe-charmet Nov 5, 2025
a8177ab
Rename task
noe-charmet Nov 6, 2025
5603f13
Remove unsued task
noe-charmet Nov 6, 2025
060688e
Merge branch 'main' into rename_biome
noe-charmet Nov 6, 2025
a2b23f9
Rename cmd
noe-charmet Nov 6, 2025
b95c2c8
Ref
noe-charmet Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-rockets-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@shipfox/biome": minor
---

Rename biome task to biome-check
Comment on lines +1 to +5
Copy link

@coderabbitai coderabbitai bot Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify that the task rename is fully implemented across the codebase.

The changeset file is well-formatted and documents a minor version bump, which is appropriate for a rename. However, this changeset alone only documents the change—ensure that:

  1. The "biome" task has actually been renamed to "biome-check" in package.json (or equivalent task definition)
  2. All references to the old task name have been updated
  3. The "biome" CLI command is now properly exposed/preserved as intended

🏁 Script executed:

#!/bin/bash
# Description: Verify the task rename from "biome" to "biome-check" is complete

# Search for task definitions in common files
echo "=== Checking package.json scripts ==="
fd package.json --type f --exec cat {} \; | grep -A 20 '"scripts"'

# Search for remaining references to the old "biome" task (excluding this changeset)
echo -e "\n=== Searching for references to 'biome' task (excluding changesets) ==="
rg -n '"biome"\s*:' --type json --type yaml -g '!.changeset'

# Check for any npm/yarn script references
echo -e "\n=== Checking for 'biome-check' task definition ==="
rg -n 'biome-check' --type json --type yaml

Length of output: 8838

🏁 Script executed:

#!/bin/bash
# Detailed verification of the biome task rename implementation

echo "=== Root package.json 'biome' task ==="
grep -A 1 '"biome"' package.json | head -2

echo -e "\n=== All occurrences of 'biome' task definition (not just description) ==="
rg -n '"biome"\s*:\s*"' --type json

echo -e "\n=== All occurrences of check scripts that reference 'biome' ==="
rg -n '"check"\s*:\s*"biome' --type json

echo -e "\n=== Check if bin/biome.js exists ==="
fd -t f -n "biome.js" 

echo -e "\n=== Check tools/biome/bin/ structure ==="
fd . tools/biome/bin/ --type f 2>/dev/null || echo "No bin directory found"

echo -e "\n=== All references to 'biome-check' (full search) ==="
rg -n 'biome-check' 2>/dev/null | wc -l

Length of output: 1340

The task rename is not implemented. The changeset documents a change that does not exist in the codebase.

The changeset claims to rename the "biome" task to "biome-check", but the actual rename is missing:

  • Root package.json still defines: "biome": "pnpm --filter @shipfox/biome exec biome"
  • tools/biome/package.json still defines: "biome": "./bin/biome.js"
  • 10 packages still reference "check": "biome" instead of "check": "biome-check"
  • Zero occurrences of "biome-check" found in the entire codebase

Either the implementation is missing from this PR or the changeset was added prematurely. Update all task definitions and references to complete the rename.

🤖 Prompt for AI Agents 
In .changeset/famous-rockets-end.md lines 1-5: the changeset says "biome" was
renamed to "biome-check" but the codebase still uses "biome"; update the
implementation to match the changeset by renaming task entries and references:
change root package.json "biome" script to "biome-check": "pnpm --filter
@shipfox/biome exec biome-check", update tools/biome/package.json script from
"biome": "./bin/biome.js" to "biome-check": "./bin/biome.js" (or rename the
binary to bin/biome-check.js and update "bin" field), search and replace the 10
package.json scripts that have "check": "biome" to "check": "biome-check", and
add/update any package.json "bin" or CLI dispatchers so "biome-check" is a valid
executable; run a repo-wide search to ensure zero remaining "biome" task
references or update the changeset if you intend not to implement the rename.

Copy link
Contributor

@kylengn kylengn Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noe-charmet please double check this

Copy link

@coderabbitai coderabbitai bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Contributor Author

@noe-charmet noe-charmet Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was failing because of this, latest changes should fix it

Copy link
Contributor

@kylengn kylengn Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noe-charmet the CI is still failing though saying the biome-check not found, can you double check again?

136 changes: 68 additions & 68 deletions .github/actions/ci/dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/actions/ci/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"type": "module",
"scripts": {
"build": "node_modules/.bin/vite-build",
"check": "node_modules/.bin/biome",
"check": "node_modules/.bin/biome-check",
"type": "node_modules/.bin/tsc-check"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/common/config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"test": "vitest-run",
"type": "tsc-emit"
},
Expand Down
2 changes: 1 addition & 1 deletion libs/node/clickhouse/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/node/feature-flag/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/node/log/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/node/opentelemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/node/pg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/node/redis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion libs/react/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "module",
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"storybook": "storybook dev",
"storybook:build": "storybook build -o storybook-static",
"test": "vitest-run",
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"license": "MIT",
"scripts": {
"preinstall": "npx only-allow pnpm",
"prepare": "husky || echo \"Husky not installed, cannot setup hooks\"",
"biome": "pnpm --filter @shipfox/biome exec biome"
"prepare": "husky || echo \"Husky not installed, cannot setup hooks\""
},
"private": false,
"packageManager": "pnpm@9.15.9",
Expand Down
0 tools/biome/bin/biome.js → tools/biome/bin/biome-check.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tools/biome/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"packageManager": "pnpm@9.15.9",
"type": "module",
"bin": {
"biome": "./bin/biome.js"
"biome-check": "./bin/biome-check.js"
},
"scripts": {
"build": "swc",
Expand Down
2 changes: 1 addition & 1 deletion tools/docker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion tools/skopeo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"scripts": {
"build": "swc",
"check": "biome",
"check": "biome-check",
"type": "tsc-emit"
},
"dependencies": {
Expand Down