Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Add support for Writer models and Palmyra X 004 #755

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samjulien
Copy link

@samjulien samjulien commented Nov 12, 2024

This PR adds support for Writer models and our latest Palmyra X 004 to BFCL. Thank you!

@samjulien samjulien changed the title Add support for Palmyra X 004 from Writer [BFCL] Add support for Writer models and Palmyra X 004 Nov 13, 2024
@samjulien samjulien marked this pull request as ready for review November 13, 2024 22:39
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @samjulien !

I noticed that here, you intentionally removed all the response field from the function doc.
For model that doesn't support response field, we add those information to the end of the function description because we don't want information loss (code here). Is there a reason why you chose to do it that way?

@samjulien
Copy link
Author

Thanks for the PR @samjulien !

I noticed that here, you intentionally removed all the response field from the function doc. For model that doesn't support response field, we add those information to the end of the function description because we don't want information loss (code here). Is there a reason why you chose to do it that way?

Ah thank you! I’ll add a check for our models there and remove from our handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants