Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Dataset and Possible Answer Fix (Live Categories) for Illegal Python Parameter Name #778

Merged
merged 7 commits into from
Nov 23, 2024

Conversation

HuanzhiMao
Copy link
Collaborator

@HuanzhiMao HuanzhiMao commented Nov 23, 2024

This PR fixes the dataset for the illegal Python parameter name issue, based on the logs that the unit test in #777 outputs.

The following entries have illegal parameter names and have been fixed. 55 entries in total.

All of the fixes are changing parameter name class -> _class.

'live_irrelevance_689-224-0', 'live_multiple_907-186-4', 'live_multiple_859-181-0', 'live_multiple_905-186-2', 'live_irrelevance_675-216-0', 'live_irrelevance_626-198-0', 'live_multiple_904-186-1', 'live_relevance_25-16-1', 'multiple_197', 'live_irrelevance_705-231-0', 'live_irrelevance_617-195-5', 'live_multiple_507-149-4', 'live_multiple_505-149-2', 'live_irrelevance_612-195-0', 'live_relevance_37-24-0', 'live_multiple_741-168-3', 'live_multiple_744-168-6', 'live_multiple_485-147-0', 'live_multiple_489-147-4', 'live_multiple_739-168-1', 'live_irrelevance_616-195-4', 'live_irrelevance_618-195-6', 'live_multiple_439-143-0', 'live_multiple_510-149-7', 'live_irrelevance_631-200-0', 'live_irrelevance_614-195-2', 'live_irrelevance_706-231-1', 'live_multiple_511-149-8', 'live_multiple_742-168-4', 'live_irrelevance_615-195-3', 'live_multiple_487-147-2', 'live_multiple_861-181-2', 'live_relevance_27-16-3', 'live_relevance_34-22-0', 'live_irrelevance_613-195-1', 'multiple_143', 'live_multiple_862-181-3', 'live_multiple_486-147-1', 'live_multiple_509-149-6', 'live_multiple_903-186-0', 'live_relevance_26-16-2', 'live_multiple_860-181-1', 'live_multiple_488-147-3', 'live_multiple_740-168-2', 'live_relevance_24-16-0', 'live_multiple_504-149-1', 'live_multiple_503-149-0', 'live_irrelevance_707-231-2', 'live_irrelevance_627-198-1', 'live_multiple_738-168-0', 'live_multiple_743-168-5', 'live_relevance_35-22-1', 'live_multiple_508-149-5', 'live_multiple_506-149-3', 'live_multiple_906-186-3'

@HuanzhiMao HuanzhiMao added the BFCL-Dataset BFCL Dataset-Related Issue label Nov 23, 2024
@CharlieJCJ
Copy link
Collaborator

CharlieJCJ commented Nov 23, 2024

So, the changes are all changing parameter names that are named class? based on #777

Answer: yes

Copy link
Collaborator

@CharlieJCJ CharlieJCJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuanzhiMao HuanzhiMao merged commit 12629f2 into ShishirPatil:main Nov 23, 2024
@HuanzhiMao HuanzhiMao deleted the data-fix branch November 23, 2024 20:28
HuanzhiMao added a commit that referenced this pull request Dec 7, 2024
This PR updates the leaderboard to reflect the change in score due to
the following PR merge:

1. #747 
2. #770 
3. #768 
4. #750 
5. #763 
6. #772 
7. #777 
8. #778 
9. #786 
10. #787 
11. #697 
12. #718 
13. #755 
14. #796 
15. #789 
16. #804 
17. #808 
18. #809
19. #811 
20. #810 

Models were evaluated using checkpoint commit d7e52e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-Dataset BFCL Dataset-Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants