This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Removed option to disable open graph and twitter cards #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshold
added a commit
that referenced
this pull request
Apr 23, 2014
Removed option to disable open graph and twitter cards
| <tr> | ||
| <td><label for="enable_twittercards">Enable <a href="https://dev.twitter.com/docs/cards/types/product-card" title="About Twitter Product Cards">Twitter Cards</a></label></td> | ||
| <td><input type="checkbox" id="enable_twittercards" name="enable_twittercards" /></td> | ||
| <td colspan="2"><small>Social meta tags include <a href="https://developers.facebook.com/docs/opengraph/using-objects/" title="About Facebook Open Graph Objects">Facebook</a> and <a href="https://developers.pinterest.com/rich_pins/" title="About Pinterest Rich Pins">Pinterest</a> Open Graph Tags and <a href="https://dev.twitter.com/docs/cards/types/product-card" title="About Twitter Product Cards">Twitter Cards</a>. These are enabled by default to make your store more accessible on different platforms. Add any required information below for them to rendor properly.</small></td> |
There was a problem hiding this comment.
A small spelling error "rendor" should be "render".
There was a problem hiding this comment.
Spelling is not my strong suit. Thanks for catching.
cimocimocimo
pushed a commit
to cimocimocimo/Theia-Shopify-Theme
that referenced
this pull request
Nov 25, 2014
Removed option to disable open graph and twitter cards
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All shops should use Facebook/Pinterest open graph tags and Twitter Cards to be more accessible on more platforms. Option to disable them has been removed.