Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Removed option to disable open graph and twitter cards #49

Merged
merged 1 commit into from
Apr 23, 2014
Merged

Removed option to disable open graph and twitter cards #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions config/settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,13 @@
<legend>Social Meta Tags</legend>
<table>
<tr>
<td colspan="2"><small>Social helpers include Facebook Open Graph Tags and Twitter Cards. Enable or disable them here, all of the code is taking care of for you in snippets.</small></td>
</tr>
<tr>
<td><label for="enable_opengraph">Enable <a href="https://developers.facebook.com/docs/opengraph/using-objects/" title="About Facebook Open Graph Objects">Facebook</a> and <br /><a href="https://developers.pinterest.com/rich_pins/" title="About Pinterest Rich Pins">Pinterest</a> Open Graph tags</label></td>
<td>
<input type="checkbox" id="enable_opengraph" name="enable_opengraph" />
<small>Open Graph tags are used by Facebook and Pinterest to load the appropriate product details when sharing or pinning.</small>
</td>
</tr>
<tr>
<td><label for="enable_twittercards">Enable <a href="https://dev.twitter.com/docs/cards/types/product-card" title="About Twitter Product Cards">Twitter Cards</a></label></td>
<td><input type="checkbox" id="enable_twittercards" name="enable_twittercards" /></td>
<td colspan="2"><small>Social meta tags include <a href="https://developers.facebook.com/docs/opengraph/using-objects/" title="About Facebook Open Graph Objects">Facebook</a> and <a href="https://developers.pinterest.com/rich_pins/" title="About Pinterest Rich Pins">Pinterest</a> Open Graph Tags and <a href="https://dev.twitter.com/docs/cards/types/product-card" title="About Twitter Product Cards">Twitter Cards</a>. These are enabled by default to make your store more accessible on different platforms. Add any required information below for them to rendor properly.</small></td>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small spelling error "rendor" should be "render".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling is not my strong suit. Thanks for catching.

</tr>
<tr>
<th><label for="twittercard_handle">Your site's Twitter Handle</label></th>
<td>
<input type="text" id="twittercard_handle" name="twittercard_handle" value="" /><br />
<small>E.g. @Shopify. Required if Twitter Cards are enabled.</small>
<small>E.g. @Shopify. Required for Twitter Cards.</small>
</td>
</tr>
</table>
Expand Down
2 changes: 0 additions & 2 deletions config/settings_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"presets": {
"Default": {
"use_logo": false,
"enable_opengraph": true,
"enable_twittercards": true,
"customer_layout": "theme",
"footer_display_contact": true,
"footer_contact_title": "Contact Us",
Expand Down
2 changes: 0 additions & 2 deletions snippets/fb-open-graph-tags.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
- https://developers.pinterest.com/rich_pins/validator/

{% endcomment %}
{% if settings.enable_opengraph %}
{% if template contains 'product' %}
<meta property="og:type" content="product">
<meta property="og:title" content="{{ product.title | strip_html | escape }}">
Expand Down Expand Up @@ -46,7 +45,6 @@
{% endif %}
{% if page_description %}
<meta property="og:description" content="{{ page_description | escape }}">
{% endif %}
{% endif %}
<meta property="og:url" content="{{ canonical_url }}">
<meta property="og:site_name" content="{{ shop.name }}">
4 changes: 0 additions & 4 deletions snippets/twitter-card.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@

{% endcomment %}

{% if settings.enable_twittercards %}

{% comment %}
Twitter user name of the site, based on theme settings
{% endcomment %}
Expand Down Expand Up @@ -51,6 +49,4 @@
<meta property="twitter:image" content="{{ src }}">
{% endif %}
{% endif %}
{% endif %}

{% endif %}