Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

IE8 bug fixes, code cleaning #79

Merged
merged 1 commit into from
May 22, 2014
Merged

IE8 bug fixes, code cleaning #79

merged 1 commit into from
May 22, 2014

Conversation

cshold
Copy link
Contributor

@cshold cshold commented May 22, 2014

  • IE8 defaults to the handlebar.js cart template in the ajax modal and drawer because it doesn't support jQuery's .load function
  • IE8 fires a resize event all the time, so now it's excluded for updating the modal size
  • Took window scroll into account when aligning modal close button
  • IE8 modal now has an overlay you can see
  • Resize and onorientationchange are only initialized once
  • Added modal overlay and close button to the setup function where they belong
  • Transition mixin no longer breaks with multiple arguments, just use quotes when passing in the transition
    • E.g. @include transition('background-color 100ms ease-in-out, margin 100ms ease-in-out');

cshold added a commit that referenced this pull request May 22, 2014
@cshold cshold merged commit 5f0ef0d into master May 22, 2014
@cshold cshold deleted the ajax-browser-checking branch June 2, 2014 19:12
cimocimocimo pushed a commit to cimocimocimo/Theia-Shopify-Theme that referenced this pull request Nov 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant