Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Fix Theme Push Execution when password flag is provided #3645

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Apr 2, 2024

WHY are these changes introduced?

WHAT is this pull request doing?

  • Calls the legacy (ruby) implementation of the push command when the password flag is provided
    • This is a temporary solution to fix the push command and any CI consumers without needing to explicitly provide the --stable flag
    • This PR will be reverted once ThemeKit adds support for calling the Bulk Upload endpoint in the Asset API

How to test your changes?

  1. Checkout Main
  2. Install the theme access app
  3. Generate a password
  4. Call pnpm shopify theme push --password <PASSWORD>
  5. Checkout this branch
  6. Repeat step 4

The first execution should have resulted in an empty theme being pushed
The second execution should result in the files being uploaded properly

Post-release steps

  • Patch release

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@jamesmengo jamesmengo requested a review from karreiro April 2, 2024 22:33
@jamesmengo jamesmengo self-assigned this Apr 2, 2024

This comment has been minimized.

@jamesmengo jamesmengo added the Area: @shopify/theme @shopify/theme package issues label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72% (-0.01% 🔻)
6751/9376
🟡 Branches
69.19% (+0.09% 🔼)
3296/4764
🟡 Functions
70.74% (-0.08% 🔻)
1799/2543
🟡 Lines
73.15% (-0.02% 🔻)
6366/8703
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / select-app.ts
65.38% (-2.47% 🔻)
50% (-16.67% 🔻)
87.5%
68.18% (-1.38% 🔻)
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1617 tests passing in 754 suites.

Report generated by 🧪jest coverage report action from 59ee23f

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jamesmengo! LGTM and works as expected as well 🎩 I've left only one minor/optional suggestion :)

Thanks for fixing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants