Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.58] Fix shopify theme push issue when password flag is provided #3651

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jamesmengo
Copy link
Contributor

[Themes] Fix Theme Push Execution when password flag is provided
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@jamesmengo jamesmengo requested a review from a team April 3, 2024 17:01
@jamesmengo jamesmengo self-assigned this Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.58.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.58.1";
\ No newline at end of file
packages/cli-kit/dist/public/node/tcp.d.ts
@@ -1,11 +1,10 @@
 /**
  * Returns an available port in the current environment.
  *
- * @param preferredPort - Number of the preferred port to be used if available.
  * @returns A promise that resolves with an availabe port.
  * @example
  */
-export declare function getAvailableTCPPort(preferredPort?: number): Promise<number>;
+export declare function getAvailableTCPPort(): Promise<number>;
 /**
  * Checks if a port is available.
  *
packages/cli-kit/dist/public/node/api/business-platform.d.ts
@@ -1,6 +1,6 @@
 import { GraphQLVariables } from './graphql.js';
 /**
- * Executes a GraphQL query against the Business Platform Destinations API.
+ * Executes a GraphQL query against the Business Platform API.
  *
  * @param query - GraphQL query to execute.
  * @param token - Business Platform token.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.2% 6746/9344
🟡 Branches 69.29% 3294/4754
🟡 Functions 70.88% 1799/2538
🟡 Lines 73.37% 6361/8670

Test suite run success

1615 tests passing in 754 suites.

Report generated by 🧪jest coverage report action from c7df7e3

@jamesmengo jamesmengo requested review from a team, Arkham and gonzaloriestra and removed request for a team April 3, 2024 17:46
@karreiro karreiro merged commit f41ab02 into stable/3.58 Apr 4, 2024
@karreiro karreiro deleted the backport_push branch April 4, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants