Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.59] Fix shopify theme dev and shopify theme console proxies following session changes and bring back the legacy shopify theme push implementation in CI/CD workflows #3774

Closed
wants to merge 2 commits into from

Conversation

karreiro
Copy link
Contributor

BackForward-port #3769 #3771

…llowing session changes and bring the legacy `shopify theme push` implementation in CI/CD workflows
@karreiro karreiro requested review from mgmanzella and lucyxiang and removed request for mgmanzella April 23, 2024 08:39
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.77% 6904/9620
🟡 Branches 68.72% 3401/4949
🟡 Functions 71.14% 1849/2599
🟡 Lines 73.08% 6506/8903

Test suite run success

1630 tests passing in 761 suites.

Report generated by 🧪jest coverage report action from bfced7d

@karreiro karreiro closed this Apr 23, 2024
@karreiro
Copy link
Contributor Author

Temporarily closed due to Rubocop CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant