Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.59] Fix shopify theme dev proxy to use development theme #3771

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Apr 23, 2024

WHY are these changes introduced?

Fix the shopify theme dev proxy to use the development theme, even when users have a browser session with the live theme loaded. I noticed this edge case while conducting additional manual tests for #3769.

WHAT is this pull request doing?

This PR updates the proxy to serve the 302 response when the development theme ID is set.

How to test your changes?

Before
before__

After
after__

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@karreiro karreiro requested a review from lucyxiang April 23, 2024 05:55
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.01% 6930/9623
🟡 Branches 69.1% 3413/4939
🟡 Functions 71.19% 1851/2600
🟡 Lines 73.29% 6535/8917

Test suite run success

1653 tests passing in 765 suites.

Report generated by 🧪jest coverage report action from 0ae2173

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.59.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.59.1";
\ No newline at end of file

@karreiro karreiro merged commit a5c2d79 into stable/3.59 Apr 23, 2024
@karreiro karreiro deleted the theme-patch-proxy-2 branch April 23, 2024 08:02
@karreiro
Copy link
Contributor Author

(back-ported #3772 to get robocop passing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants