Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shopify theme dev and shopify theme console proxies following session changes and bring back the legacy shopify theme push implementation in CI/CD workflows #3791

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

karreiro
Copy link
Contributor

Back forward-port #3769 #3771

- Fix `shopify theme dev` and `shopify theme console` proxies following session changes and bring the legacy `shopify theme push` implementation in CI/CD workflows
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.85% 6938/9656
🟡 Branches 68.74% 3417/4971
🟡 Functions 71.25% 1859/2609
🟡 Lines 73.16% 6539/8938

Test suite run success

1633 tests passing in 762 suites.

Report generated by 🧪jest coverage report action from d5a05e7

Copy link
Contributor

@mgmanzella mgmanzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @karreiro !

@karreiro karreiro added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 1ef19f6 Apr 29, 2024
1 check passed
@karreiro karreiro deleted the theme-patch-proxy-main-2 branch April 29, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants