Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a root <Text> element to log files to fix wrapping #3959

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

nickwesselman
Copy link
Contributor

Fixed a wrapping issue introduced in ConcurrentOutput in #3797

Before

image

After

image

@nickwesselman nickwesselman requested a review from isaacroldan May 31, 2024 13:42
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented May 31, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.94% (-0.01% 🔻)
7236/10059
🟡 Branches
69.06% (-0.02% 🔻)
3565/5162
🟡 Functions 71.57% 1936/2705
🟡 Lines
73.2% (-0.01% 🔻)
6813/9307
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88.89% (-5.56% 🔻)
100%
98.31% (-1.69% 🔻)

Test suite run success

1684 tests passing in 781 suites.

Report generated by 🧪jest coverage report action from 7b1ab59

@nickwesselman nickwesselman force-pushed the concurrentoutput-wrapping-fix branch from 037fab6 to 7b1ab59 Compare June 4, 2024 12:25
@nickwesselman nickwesselman added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 2f9a1c8 Jun 4, 2024
@nickwesselman nickwesselman deleted the concurrentoutput-wrapping-fix branch June 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants