-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a root <Text> element to log files to fix wrapping (3.61 patch) #3960
add a root <Text> element to log files to fix wrapping (3.61 patch) #3960
Conversation
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1682 tests passing in 780 suites. Report generated by 🧪jest coverage report action from 481d802 |
|
@shauns I can't merge due to CI checks being broken |
@nickwesselman It should be fixed now, just rebase with main :) |
@isaacroldan This is a 3.61 patch though, do we need to apply the CI fix on this patch branch too? |
Um, good point. I can remove the checks of node 18.12 for now as an alternative |
Actually, those aren't required here. So you can merge 👌 |
3.61 patch for #3959