Clean up unused flags from app logs file #4461
Merged
+1
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmengo
force-pushed
the
jm/cleanlog
branch
from
529e340
to
eaf22b6
Compare
jamesmengo
force-pushed
the
jm/cleanlog
branch
from
eaf22b6
to
f27e6e5
Compare
jamesmengo
force-pushed
the
jm/cleanlog
branch
from
f27e6e5
to
d887a97
Compare
jamesmengo
changed the title
stable flag from logs.ts
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1889 tests passing in 857 suites. Report generated by 🧪jest coverage report action from d887a97 |
jamesmengo
requested review from
a team,
jantnovi,
craigmichaelmartin,
DuncanUszkay1,
saga-dasgupta,
alexandres and
lopert
and removed request for
a team,
jantnovi,
craigmichaelmartin and
alexandres
DuncanUszkay1
approved these changes
Sep 19, 2024
lopert
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes https://github.com/Shopify/develop-advanced-edits/issues/338
WHAT is this pull request doing?
Remove unused flags in
logs.tsMeasuring impact
How do we know this change was effective? Please choose one:
Checklist