Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused flags from app logs file #4461

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Clean up unused flags from app logs file #4461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/app/src/cli/commands/app/logs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ export default class Logs extends Command {
parse: async (input) => normalizeStoreFqdn(input),
}),
reset: Dev.flags.reset,
'no-tunnel': Dev.flags['no-tunnel'],
'graphiql-port': Dev.flags['graphiql-port'],
'graphiql-key': Dev.flags['graphiql-key'],
stable: Dev.flags.legacy,
source: Flags.string({
description: 'Filters output to the specified log source.',
env: 'SHOPIFY_FLAG_SOURCE',
Expand All @@ -60,14 +56,12 @@ export default class Logs extends Command {

const apiKey = flags['client-id'] || flags['api-key']

const sources = flags.source

await checkFolderIsValidApp(flags.path)
const logOptions = {
apiKey,
directory: flags.path,
storeFqdns: flags.store,
sources,
sources: flags.source,
status: flags.status,
configName: flags.config,
reset: flags.reset,
Expand Down
38 changes: 0 additions & 38 deletions packages/cli/oclif.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,24 +1584,6 @@
"name": "config",
"type": "option"
},
"graphiql-key": {
"description": "Key used to authenticate GraphiQL requests. Should be specified if exposing GraphiQL on a publicly accessible URL. By default, no key is required.",
"env": "SHOPIFY_FLAG_GRAPHIQL_KEY",
"hasDynamicHelp": false,
"hidden": true,
"multiple": false,
"name": "graphiql-key",
"type": "option"
},
"graphiql-port": {
"description": "Local port of the GraphiQL development server.",
"env": "SHOPIFY_FLAG_GRAPHIQL_PORT",
"hasDynamicHelp": false,
"hidden": true,
"multiple": false,
"name": "graphiql-port",
"type": "option"
},
"json": {
"allowNo": false,
"char": "j",
Expand All @@ -1618,18 +1600,6 @@
"name": "no-color",
"type": "boolean"
},
"no-tunnel": {
"allowNo": false,
"description": "Automatic creation of a tunnel is disabled. Service entry point will listen to localhost instead",
"env": "SHOPIFY_FLAG_NO_TUNNEL",
"exclusive": [
"tunnel-url",
"tunnel"
],
"hidden": true,
"name": "no-tunnel",
"type": "boolean"
},
"path": {
"description": "The path to your app directory.",
"env": "SHOPIFY_FLAG_PATH",
Expand Down Expand Up @@ -1658,14 +1628,6 @@
"name": "source",
"type": "option"
},
"stable": {
"allowNo": false,
"description": "Use the legacy Ruby implementation for managing theme app extensions.",
"env": "SHOPIFY_FLAG_LEGACY",
"hidden": true,
"name": "stable",
"type": "boolean"
},
"status": {
"description": "Filters output to the specified status (success or failure).",
"env": "SHOPIFY_FLAG_STATUS",
Expand Down