Fix multiple corrections on same offense #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mangoov
force-pushed
the
fix-multiple-correction-same-offense
branch
2 times, most recently
from
fa7a22f
to
ce71ecf
Compare
Mangoov
changed the title
Mangoov
force-pushed
the
fix-multiple-correction-same-offense
branch
from
ce71ecf
to
c9cf164
Compare
Mangoov
force-pushed
the
fix-multiple-correction-same-offense
branch
from
c9cf164
to
c44636e
Compare
EiNSTeiN-
reviewed
Feb 20, 2018
lib/erb_lint/cli.rb
Outdated
| @@ -113,6 +115,7 @@ def run_with_corrections(filename) | |||
| end | |||
|
|
|||
| file_content = corrector.corrected_content | |||
| break if previous_offenses.eql?(runner.offenses) | |||
There was a problem hiding this comment.
Won't the instance of this array always be equal to itself?
There was a problem hiding this comment.
You're right, I changed the strategy to instead clear the ivars at the end of the loop
There was a problem hiding this comment.
🆒 since the list is append-only you could also look at the array size
EiNSTeiN-
approved these changes
Feb 20, 2018
Edouard-chin
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69 introduced stored offenses in an instance variable
@offenses.However this makes it so the break condition of the lopp: https://github.com/Shopify/erb-lint/blob/8b7863485fd9d9cdb36f83af8cc87cb0fc50b683/lib/erb_lint/cli.rb#L102-L103
Will only break if no offenses are detected on the first pass, if an offense is detected the first time, the loop will not break because the offences are now stored in the ivar
@offenseof the runner.To circumvent this, I am comparing what the previous offenses were and breaking if there are no changes at the end of the iteration.
This PR also fixes a few misleading messages on offense