Remove unnecessary context_evaluate call when executing OP_FIND_VAR

Shopify · Sep 30, 2020 · 5cee268 · 5cee268
1 parent 4d108a8
commit 5cee268
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/ext/liquid_c/context.c b/ext/liquid_c/context.c
@@ -8,7 +8,7 @@ ID id_aset, id_set_context;
 static ID id_has_key, id_aref;
 static ID id_ivar_scopes, id_ivar_environments, id_ivar_static_environments, id_ivar_strict_variables;
 
-VALUE context_evaluate(VALUE self, VALUE expression)
+static VALUE context_evaluate(VALUE self, VALUE expression)
 {
     // Scalar type stored directly in the VALUE, this needs to be checked anyways to use RB_BUILTIN_TYPE
     if (RB_SPECIAL_CONST_P(expression))

diff --git a/ext/liquid_c/context.h b/ext/liquid_c/context.h
@@ -2,7 +2,6 @@
 #define LIQUID_CONTEXT_H
 
 void init_liquid_context();
-VALUE context_evaluate(VALUE self, VALUE expression);
 VALUE context_find_variable(VALUE self, VALUE key, VALUE raise_on_not_found);
 void context_maybe_raise_undefined_variable(VALUE self, VALUE key);
 

diff --git a/ext/liquid_c/vm.c b/ext/liquid_c/vm.c
@@ -297,7 +297,7 @@ static VALUE vm_render_until_error(VALUE uncast_args)
             {
                 VALUE key = vm_stack_pop(vm);
                 VALUE value = context_find_variable(args->context, key, Qtrue);
-                vm_stack_push(vm, context_evaluate(args->context, value));
+                vm_stack_push(vm, value);
                 break;
             }
             case OP_LOOKUP_CONST_KEY: