-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install problem #125
Comments
And btw on the same machine I can build liquid-c .. |
Looks like other gems get that warning and it is just that liquid-c is being compiled with -Werror which turns warnings into errors. Seems like we need to backport #124 to workaround this problem. Although, it also seems like homebrew should be able to install ruby in a way that doesn't cause this warning, since this doesn't seem to be a problem with ruby on CI or the one I installed locally using ruby-install
Do you mean using liquid-c master? |
It seems like this option it is complaining about is coming from https://github.com/ruby/ruby/blob/v2_7_2/configure.ac#L513 where it seems like the option is being added to CFLAGS by ruby's configure script if it is supported. Those same CFLAGS then get used to compile extensions. Homebrew uses pre-compiled binaries, so I think the compiler used to build the pre-compiled binary supports this flag, but the local compiler doesn't. So you may want to try running MacOS software updates to see if this fixes the issue, since it may be that you are using an older version of Xcode compared to the one to build pre-compiled binaries for homebrew. |
A couple of things:
|
I gave up on liquid-c .. |
Run
|
I am using liquid-c in my jekyll based site and cant seem to get it to install on one workstation.
Ruby is installed with brew and the usual configurations are in place. I reinstalled Ruby and did a bunch of other trials, but always end up with this problem. The same site and setup works on other machines and on this machine with using jekyll-docker.
Any tip on what to look at?
The text was updated successfully, but these errors were encountered: