Remove error on compiler warnings by default, except on CI #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
approved these changes
Nov 10, 2020
|
Tobi already committed the fix for this compiler error in commit b435341 |
Closed
dylanahsmith
added a commit
that referenced
this pull request
Feb 11, 2021
(cherry picked from commit c86424c)
dylanahsmith
added a commit
that referenced
this pull request
Feb 11, 2021
(cherry picked from commit c86424c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@tobi encountered a compiler warning that was treated as an error due when trying to compile liquid-c on linux with gcc 9.3.
This wasn't an error that was caught by CI and I wasn't able to reproduce this and I don't think we should have confidence that we can catch all compiler warnings before another developer experiences them.
Solution
Only treat warnings as errors by default on CI. We can set the
LIQUID_C_PENDANTICenvironment variable to opt-in to this locally.