Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_evaluating_a_variable_entirely_within_c
test is flaky. If we do the following:We can see output such as:
And the failure is:
I was able to reproduce this on Ruby 2.5.8 using seed 7822 (the repro is flaky and requires multiple tries).
As you can see, there are various other methods called that are also C functions.
The solution is to ignore all C function calls unless the class it is called on starts with
Liquid
.