Require source code to be at most 16MiB #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
reviewed
Oct 9, 2020
lib/liquid/c.rb
Outdated
| alias_method :ruby_parse, :parse | ||
|
|
||
| def c_parse(source, options = {}) | ||
| if source.bytesize > Liquid::Template::MAX_SOURCE_CODE_BYTES |
There was a problem hiding this comment.
I think it would be simpler do this is on an existing parsing code path, rather than introducing another monkey patch. Also, we generally do the safety checks for C code in the C code itself, which avoids the ability for ruby code to trigger undefined behaviour. So I would do it in tokenizer_initialize_method after the existing source checks.
peterzhu2118
force-pushed
the
pz-max-source-code-bytes
branch
from
880d132 to
9335dc3
Compare
dylanahsmith
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise when source is larger than 16MiB in
Liquid::Template#parse. This will let us use this assumption in liquid-c.See #79.