Add a Money/UnsafeToMoney cop #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiUngur
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
LGTM 👍
Seems like there are no "code-owners" defined? But I think this change should be harmless given that it's adding an optional cop. Should also be safe to revert if anything;
I wonder if we should link this comment in the code as a justification for the cop? I really don't feel strongly : #250 (comment)
cc @elfassy
elfassy
approved these changes
Jun 20, 2023
|
Thanks for this PR! ❤️ |
bslobodin
reviewed
Jun 20, 2023
Merged
|
PR to deprecated the legacy behaviour for new apps #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a potentially dangerous use of the Fuzzy parser.
See comment for detail and #250 (comment) for context