Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing require for Rubocop rule #266

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Add missing require for Rubocop rule #266

merged 2 commits into from
Jun 20, 2023

Conversation

lavoiesl
Copy link
Contributor

@lavoiesl lavoiesl commented Jun 20, 2023 •
edited
Loading

Rule introduced in #264

Otherwise, include the gem doesn't expose the rule:

$ bin/rubocop --only Money/UnsafeToMoney
Error: unrecognized cop or department Money/UnsafeToMoney found in .rubocop.yml
Did you mean `Money/ZeroMoney`?

AndreiUngur
AndreiUngur approved these changes Jun 20, 2023
View reviewed changes
Copy link

@AndreiUngur AndreiUngur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@lavoiesl lavoiesl merged commit b35448a into master Jun 20, 2023
@lavoiesl lavoiesl deleted the seb-rubocop-require branch June 20, 2023 18:26
@shopify-shipit shopify-shipit bot temporarily deployed to production June 20, 2023 18:29 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production June 21, 2023 20:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreiUngur AndreiUngur AndreiUngur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavoiesl @AndreiUngur