chore: add version command #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
approved these changes
Feb 24, 2023
| @@ -3,6 +3,8 @@ | |||
|
|
|||
| ENV["RAILS_ENV"] = "test" | |||
|
|
|||
| require "pathname" | |||
There was a problem hiding this comment.
This isn't needed for our setup, but I assume you ran tests without rake to get the error (via ruby -I). In that case, we can keep it 👍
There was a problem hiding this comment.
This was an issue on my part, I ran with global rake and saw this issue, running with bundle exec rake resolved it.
* Added in test for version command * Removed dead auto autoloader for Version
silasb
force-pushed
the
chore/add-version-command
branch
from
bcfb5ad
to
722d7a5
Compare
|
Thanks! For anyone else having issues with this on version of packwerk, you can use |
gmcgibbon
added a commit
that referenced
this pull request
Mar 1, 2023
The version isn't required, so the version command won't work when the gemspec isn't loaded (eg. when used in an app). #310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I was debugging issues with the newest 2.3.0 release and was having difficulties knowing what version I was running.
I noticed an error (I can pull this out into another PR if needed) while running
rake, it failed to run specs because a missingrequire "pathname".What approach did you choose and why?
I choose to add a
versioncommand in to make it easy for anyone runningbundle exec packwerkto get the version. It feels like best practice to always provide aversioncommand or flag for a CLI application.What should reviewers focus on?
The output. I'm not sure if we'd want to use 'v' prefix in-front of the version number.
Type of Change
Additional Release Notes
Checklist