Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing version require #314

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add missing version require #314

merged 1 commit into from
Mar 1, 2023

Conversation

gmcgibbon
Copy link
Member

@gmcgibbon gmcgibbon commented Mar 1, 2023

What are you trying to accomplish?

Fix packwerk version

What approach did you choose and why?

The version isn't required, so the version command won't work when the gemspec isn't loaded (eg. when used in an app). #310

What should reviewers focus on?

I assumed since we depend on bundler, when an app requires gems, the gemspecs would be evaluated. This seems to be incorrect testing in an app. We could add an autoload for it instead, but it is just a string constant.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

The version isn't required, so the version command won't work when the
gemspec isn't loaded (eg. when used in an app). #310
@gmcgibbon gmcgibbon requested a review from a team as a code owner March 1, 2023 19:26
@gmcgibbon gmcgibbon merged commit 3b766e1 into main Mar 1, 2023
@gmcgibbon gmcgibbon deleted the add_missing_version_require branch March 1, 2023 19:39
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 1, 2023 19:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants