Skip to content

[Thumbnail] Consolidate conditional logic #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

[Thumbnail] Consolidate conditional logic #10171

merged 1 commit into from
Aug 23, 2023

Conversation

@sophschneider
Copy link
Contributor

@sophschneider sophschneider commented Aug 22, 2023

WHY are these changes introduced?

Fixes #9973

WHAT is this pull request doing?

  • Consolidate se23 logic and styles for the Thumbnail Component

How to 🎩

  • Compare production and this PR's chromatic storybook to make sure styles are the same

Production
This PR

@sophschneider sophschneider added the 🤖Skip Comment Check Skip the migrator comment CI check label Aug 22, 2023
@sophschneider sophschneider marked this pull request as ready for review August 22, 2023 19:26
laurkim
laurkim approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sophschneider sophschneider merged commit ee95a57 into next Aug 23, 2023
@sophschneider sophschneider deleted the sophie/thumbnail-cleanup branch August 23, 2023 16:12
sam-b-rose added a commit that referenced this pull request Aug 25, 2023
@sam-b-rose
Merge branch 'next' into update-next
8cf63b7 
* next: (87 commits)
  [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant` (#9997)
  [LegacyTabs] Consolidate se23 styles and logic (#10231)
  [v12] Update changesets (#10232)
  [LegacyFilters] Consolidate se23 styles and logic (#10217)
  [Banner] Change status prop to tone (#10206)
  Replace icon highlight color in box stories (#10226)
  [TopBar] Consolidate se23 styles and logic (#10221)
  [Filters] consolidate se23 logic and styles (#10178)
  [Icon] Update props (#10220)
  [ButtonGroup] Update variant plain prop name (#10222)
  [Button] Remove connectedDisclosure (#10182)
  [LegacyCard] Consolidate se23 styles and logic (#10207)
  [Navigation] Consolidate se23 logic and styles (#10213)
  [Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196)
  [OptionList] consolidate se23 styles and logic  (#10177)
  [Page] Consolidate se23 styles and logic (#10187)
  [DataTable] Consolidate conditional logic (#10169)
  [Thumbnail] Consolidate conditional logic (#10171)
  [ResourceItem] Consolidate conditional logic (#10172)
  [FullscreenBar] Consolidate conditional logic (#10173)
  ...
sam-b-rose added a commit that referenced this pull request Aug 25, 2023
@sam-b-rose
Merge branch 'next' into update-next
6b4c634 
* next: (87 commits)
  [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant` (#9997)
  [LegacyTabs] Consolidate se23 styles and logic (#10231)
  [v12] Update changesets (#10232)
  [LegacyFilters] Consolidate se23 styles and logic (#10217)
  [Banner] Change status prop to tone (#10206)
  Replace icon highlight color in box stories (#10226)
  [TopBar] Consolidate se23 styles and logic (#10221)
  [Filters] consolidate se23 logic and styles (#10178)
  [Icon] Update props (#10220)
  [ButtonGroup] Update variant plain prop name (#10222)
  [Button] Remove connectedDisclosure (#10182)
  [LegacyCard] Consolidate se23 styles and logic (#10207)
  [Navigation] Consolidate se23 logic and styles (#10213)
  [Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196)
  [OptionList] consolidate se23 styles and logic  (#10177)
  [Page] Consolidate se23 styles and logic (#10187)
  [DataTable] Consolidate conditional logic (#10169)
  [Thumbnail] Consolidate conditional logic (#10171)
  [ResourceItem] Consolidate conditional logic (#10172)
  [FullscreenBar] Consolidate conditional logic (#10173)
  ...
sophschneider added a commit that referenced this pull request Sep 19, 2023
@sophschneider
[Thumbnail] Consolidate conditional logic (#10171)
cd2f41d 
### WHY are these changes introduced?

Fixes #9973

### WHAT is this pull request doing?

* Consolidate se23 logic and styles for the `Thumbnail` Component

### How to 🎩
* Compare production and this PR's chromatic storybook to make sure
styles are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-thumbnail--all&globals=polarisSummerEditions2023:true)
[This PR]()
@sam-b-rose sam-b-rose mentioned this pull request Sep 19, 2023
Merged
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@sophschneider
[Thumbnail] Consolidate conditional logic (Shopify#10171)
7ae7c4a 
### WHY are these changes introduced?

Fixes Shopify#9973

### WHAT is this pull request doing?

* Consolidate se23 logic and styles for the `Thumbnail` Component

### How to 🎩
* Compare production and this PR's chromatic storybook to make sure
styles are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-thumbnail--all&globals=polarisSummerEditions2023:true)
[This PR]()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurkim laurkim laurkim approved these changes

@gwyneplaine gwyneplaine Awaiting requested review from gwyneplaine

Assignees

No one assigned

Labels

🤖Skip Comment Check Skip the migrator comment CI check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sophschneider @laurkim