[Typography foundations] Add deprecation warnings for existing Text components #6605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
sarahill
approved these changes
Jul 12, 2022
Contributor
sarahill
left a comment
sarahill
left a comment
There was a problem hiding this comment.
Looks good! 👏 Just some minor spelling suggestions.
aveline
approved these changes
Jul 12, 2022
Contributor
aveline
left a comment
aveline
left a comment
There was a problem hiding this comment.
Looks good overall! Just a few typos to fix up, including several instances of componant. 😁
We should also create a release branch to point it to rather than main. Maybe something like release-text-component. We can always rename it later.
Contributor
Author
Agreed! |
alex-page
force-pushed
the
main
branch
7 times, most recently
from
a3a40bb to
0281d22
Compare
laurkim
reviewed
Jul 15, 2022
laurkim
approved these changes
Jul 15, 2022
Contributor
laurkim
left a comment
laurkim
left a comment
There was a problem hiding this comment.
let's gooo! 🚀 💯
I created a new deprecate-type-components branch and changed your pr to merge into that instead of main. I had one suggestion re: changeset content but it's not blocking.
alex-page
reviewed
Jul 19, 2022
laurkim
reviewed
Aug 24, 2022
chazdean
changed the base branch from
deprecate-type-components
to
typography-beta-release
laurkim
force-pushed
the
typography-beta-release
branch
2 times, most recently
from
cd45e9e to
f75fdd8
Compare
laurkim
reviewed
Sep 2, 2022
chazdean
force-pushed
the
feat/add-deprecation-warnings-text-components
branch
from
40c2ecb to
fdcc3e3
Compare
laurkim
force-pushed
the
typography-beta-release
branch
from
29923e4 to
19e7c3d
Compare
laurkim
force-pushed
the
typography-beta-release
branch
3 times, most recently
from
cfa8688 to
15b7276
Compare
laurkim
force-pushed
the
typography-beta-release
branch
from
15b7276 to
a3710e2
Compare
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim
force-pushed
the
feat/add-deprecation-warnings-text-components
branch
from
4f26dd1 to
e360f94
Compare
laurkim
added a commit
that referenced
this pull request
Nov 3, 2022
…omponents (#6605) ~~#### WARNING⚠️ ~~ ~~https://polaris.shopify.com/components/text is not currently active~~ ~~Do Not Merge!~~ Fixes #6537 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> Add deprecation warnings to all of the following existing Text components: - TextStyle - DisplayText - Heading - Subheading - Caption - VisuallyHidden | Text component | `console.log` | | --- | --- | | <img width="870" alt="Screen Shot 2022-07-12 at 10 12 53 AM" src="https://user-images.githubusercontent.com/59836805/178513139-742442e5-ccdc-4591-b0ad-b5ad0a19cbf0.png"> | <img width="633" alt="Screen Shot 2022-07-12 at 10 12 23 AM" src="https://user-images.githubusercontent.com/59836805/178513188-95c3db0e-0536-4de8-8396-fc36cf876818.png"> | Co-authored-by: Lo Kim <lo.kim@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#### WARNING⚠️ https://polaris.shopify.com/components/text is not currently activeDo Not Merge!WHY are these changes introduced?
Fixes #6537
WHAT is this pull request doing?
Add deprecation warnings to all of the following existing Text components:
console.log