Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

[quilt_rails] Engine append mount breaks performance report only apps #1602

Closed
2 tasks done
gmcgibbon opened this issue Aug 19, 2020 · 0 comments · Fixed by #1605
Closed
2 tasks done

[quilt_rails] Engine append mount breaks performance report only apps #1602

gmcgibbon opened this issue Aug 19, 2020 · 0 comments · Fixed by #1605
Assignees
@gmcgibbon
Labels
Gem: quilt_rails Type: Bug 🐛 Something isn't working

Comments

@gmcgibbon
Copy link
Member

Overview

An app can opt into performance tracking via POST /performance_report and not use quilt for SSR / react server proxying. #1576 assumes the UI controller will always be used.

We need to expose a config option in the gem to disable automatic mounting for this use-case.
...

Consuming repo

https://github.com/Shopify/partners

...

Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gmcgibbon gmcgibbon

Labels
Gem: quilt_rails Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow engine mounting to be disabled Shopify/quilt
1 participant
@gmcgibbon