This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Append engine mount #1576
Merged
Append engine mount #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
route_append
branch
2 times, most recently
from
2cde17a to
9cef600
Compare
Edouard-chin
approved these changes
Aug 5, 2020
michenly
reviewed
Aug 5, 2020
gmcgibbon
force-pushed
the
route_append
branch
from
86b2e3a to
e2a0047
Compare
michenly
approved these changes
Aug 10, 2020
Since we aren't using edge rails in our tests we either have to wait for a release or test against edge (and other versions we support in a test matrix). Right now I think it is fine to merge as-is and worry about more granular testing later. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds automatic engine mounting via a prepend hook. This is to prevent other engine routes being overridden by the main engine mount. If the gem automatically prepends the quilt engine, then other engines can draw on the application routes without worrying about precedence.
Type of change
Checklist