Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Allow engine mounting to be disabled #1605

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Allow engine mounting to be disabled #1605

merged 2 commits into from
Aug 24, 2020

Conversation

gmcgibbon
Copy link
Member

@gmcgibbon gmcgibbon commented Aug 19, 2020

Description

Closes #1602

Allow engine route mounting to be disabled for apps that only use specific controllers.

You can either do it in config/environments/*.rb in config.quilt.mount or directly via Quilt.configuration / Quilt.configure. This change also allows config options to be changed via config.quilt.* without breaking existing API.

Type of change

  • quilt_rails Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@gmcgibbon gmcgibbon force-pushed the config_mount branch 2 times, most recently from 47bf206 to 8fbebb6 Compare August 20, 2020 22:22
@gmcgibbon gmcgibbon merged commit 83e7ddf into master Aug 24, 2020
@gmcgibbon gmcgibbon deleted the config_mount branch August 24, 2020 17:51
@gmcgibbon gmcgibbon temporarily deployed to gem August 24, 2020 19:15 Inactive
@keyfer keyfer temporarily deployed to production August 26, 2020 18:40 Inactive
@ismail-syed ismail-syed deployed to pr-fix-beta-test August 31, 2020 15:04 Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quilt_rails] Engine append mount breaks performance report only apps
4 participants